rename engine metadata to template_engine #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lebouquetin
reviewed
Jul 8, 2024
jssg/models.py
Outdated
| @@ -91,7 +91,7 @@ def convert_case(match_obj): | |||
| # extras=["fenced-code-blocks", "tables"], | |||
| # ) | |||
|
|
|||
| if "engine" in self.metadata.keys() and self.metadata["engine"] == "jinja2" : | |||
| if "template_engine" in self.metadata.keys() and self.metadata["template_engine"] == "jinja2" : | |||
There was a problem hiding this comment.
Is there a way to make jinja2 default template engine?
I mean, instead of something like
if metadata and engine = "jinja2":
[...]
else:
[...]
having something like:
if metadata and engine = "django":
[...]
else:
[...]
(the else being the default behavior and having jinja2 as the default behavior except if explicitly asked for django template)
There was a problem hiding this comment.
If it's not trivial, then just tell it to me and we merge like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18